search

lark-parser / lark_cython

Cython plugin for Lark, reimplementing the LALR parser & lexer for better performance
MIT License
44 stars 5 forks source link

Fix wheels #13

Closed Erotemic closed 1 year ago

Erotemic commented 1 year ago

Follow on to conversation in #3

Quick test to determine if small tweaks can fix the wheels.

Erotemic commented 1 year ago

@erezsh I did get the pypy build step working, it seems like it needed a major and minor version. I wasn't able to figure out why 3.6 was failing in the build step. I tried the solution from https://github.com/actions/setup-python/issues/162 but it didn't seem to work.

However, looking at the yaml file, I don't think the build job is even necessary. It builds the wheels, tests them, and then does nothing. All of the wheels uploaded as artifacts come from build_binary_wheels and build_sdist. So I simply removed the build step, and I think it's working (it hasn't passed all tests yet).

I also took the liberty of adding 3.11 to as a build target in pyproject.toml, adding dependabot, and doing general cleanup of comment cruft.

erezsh commented 1 year ago

@Erotemic Makes sense! Thank you very much for your help.

Any chance you could flatten the commits before I merge?

erezsh commented 1 year ago

Awesome, thanks a lot!!