larkery / zsh-histdb

A slightly better history for zsh
MIT License
1.25k stars 74 forks source link

Add support to zsh's HISTORY_IGNORE parameter. #122

Closed ericbn closed 3 months ago

ericbn commented 2 years ago

Also set missing local and global variables, so no warning is emitted when WARN_CREATE_GLOBAL is set.

ericbn commented 2 years ago

Maybe _BORING_COMMANDS could be deprecated in favor of other zsh options:

The pro of using the same parameters as zsh is that both zsh's history and histdb's history will be configured the same way.

ericbn commented 2 years ago

Giving it a second thought on HIST_NO_STORE, to be compatible with what zsh actually does, it might be better to do:

if [[ -o histnostore && ${cmd} == (builtin |)(history( *|)|r( *|)|fc -l*) ]]; then
    return 0
fi
larkery commented 3 months ago

I only just saw this and I like it. I will fix it up and merge when I have time, thank you.

larkery commented 3 months ago

Slow turnaround I know but you get what you pay for in opensource software right.