Closed ddsjoberg closed 1 year ago
Hey @larmarange ! This is now ready for review. We can delete the Remotes:
field in the DESCRIPTION file at any time, but I think it would be useful to keep it for a bit while I make similar updates to the downstream pkgs.
Thank you @ddsjoberg and @hadley for your reactivity
Hey @larmarange ! This is now ready for review. We can delete the
Remotes:
field in the DESCRIPTION file at any time, but I think it would be useful to keep it for a bit while I make similar updates to the downstream pkgs.
Thanks @ddsjoberg
Yes, I think safer to wait for few days to be able to re-run all checks before removing the remotes, re-checking and merging the PR.
Hey hey @larmarange !
What are your thoughts on making a release? It would be helpful so I can begin making releases of the dependencies (and the dependencies of the dependencies). Is there anything you'd like me to check first?
Yes. It is a good idea. Let me re run all checks with the remote, and then re-run without the remote, then merge, proceed to revdepchecks and then prepare a release
All checks OK. I will remove the Remotes and re-run the checks
Merging #174 (95ce665) into main (6b031e0) will increase coverage by
0.01%
. The diff coverage is100.00%
.
Remotes:
to DESCRIPTION. We can delete that, but I just wanted to check the changes using the dev versions on GH Actions as well (everything passes locally)tidy.Rmd
vignette when emmeans is not available because it was used.closes #173