larmarange / broom.helpers

A set of functions to facilitate manipulation of tibbles produced by broom
https://larmarange.github.io/broom.helpers/
GNU General Public License v3.0
21 stars 8 forks source link

tidyselect v1.2.0 updates #174

Closed ddsjoberg closed 1 year ago

ddsjoberg commented 1 year ago

closes #173

ddsjoberg commented 1 year ago

Hey @larmarange ! This is now ready for review. We can delete the Remotes: field in the DESCRIPTION file at any time, but I think it would be useful to keep it for a bit while I make similar updates to the downstream pkgs.

larmarange commented 1 year ago

Thank you @ddsjoberg and @hadley for your reactivity

larmarange commented 1 year ago

Hey @larmarange ! This is now ready for review. We can delete the Remotes: field in the DESCRIPTION file at any time, but I think it would be useful to keep it for a bit while I make similar updates to the downstream pkgs.

Thanks @ddsjoberg

Yes, I think safer to wait for few days to be able to re-run all checks before removing the remotes, re-checking and merging the PR.

ddsjoberg commented 1 year ago

Hey hey @larmarange !

What are your thoughts on making a release? It would be helpful so I can begin making releases of the dependencies (and the dependencies of the dependencies). Is there anything you'd like me to check first?

larmarange commented 1 year ago

Yes. It is a good idea. Let me re run all checks with the remote, and then re-run without the remote, then merge, proceed to revdepchecks and then prepare a release

larmarange commented 1 year ago

All checks OK. I will remove the Remotes and re-run the checks

codecov[bot] commented 1 year ago

Codecov Report

Merging #174 (95ce665) into main (6b031e0) will increase coverage by 0.01%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/larmarange/broom.helpers/pull/174/graphs/tree.svg?width=650&height=150&src=pr&token=onefg3YI04&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange)](https://codecov.io/gh/larmarange/broom.helpers/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) ```diff @@ Coverage Diff @@ ## main #174 +/- ## ========================================== + Coverage 98.89% 98.90% +0.01% ========================================== Files 38 38 Lines 1623 1643 +20 ========================================== + Hits 1605 1625 +20 Misses 18 18 ``` | [Impacted Files](https://codecov.io/gh/larmarange/broom.helpers/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) | Coverage Δ | | |---|---|---| | [R/model\_get\_model\_matrix.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9tb2RlbF9nZXRfbW9kZWxfbWF0cml4LlI=) | `96.15% <ø> (ø)` | | | [R/model\_get\_terms.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9tb2RlbF9nZXRfdGVybXMuUg==) | `100.00% <ø> (ø)` | | | [R/tidy\_add\_estimate\_to\_reference\_rows.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui90aWR5X2FkZF9lc3RpbWF0ZV90b19yZWZlcmVuY2Vfcm93cy5S) | `100.00% <ø> (ø)` | | | [R/assert\_package.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9hc3NlcnRfcGFja2FnZS5S) | `100.00% <100.00%> (ø)` | | | [R/model\_identify\_variables.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9tb2RlbF9pZGVudGlmeV92YXJpYWJsZXMuUg==) | `89.77% <100.00%> (ø)` | | | [R/model\_list\_variables.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9tb2RlbF9saXN0X3ZhcmlhYmxlcy5S) | `100.00% <100.00%> (ø)` | | | [R/select\_utilities.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9zZWxlY3RfdXRpbGl0aWVzLlI=) | `98.32% <100.00%> (ø)` | | | [R/tidy\_add\_contrasts.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui90aWR5X2FkZF9jb250cmFzdHMuUg==) | `100.00% <100.00%> (ø)` | | | [R/tidy\_add\_header\_rows.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui90aWR5X2FkZF9oZWFkZXJfcm93cy5S) | `100.00% <100.00%> (ø)` | | | [R/tidy\_add\_reference\_rows.R](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui90aWR5X2FkZF9yZWZlcmVuY2Vfcm93cy5S) | `100.00% <100.00%> (ø)` | | | ... and [2 more](https://codecov.io/gh/larmarange/broom.helpers/pull/174/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) | |