search

larmarange / broom.helpers

A set of functions to facilitate manipulation of tibbles produced by broom
https://larmarange.github.io/broom.helpers/
GNU General Public License v3.0
22 stars 7 forks source link

Compatibility with dev version of purrr #181

Closed larmarange closed 2 years ago

larmarange commented 2 years ago

See https://github.com/tidyverse/purrr/issues/969

codecov[bot] commented 2 years ago

Codecov Report

Merging #181 (a32e76f) into main (3cdccea) will increase coverage by 1.35%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/larmarange/broom.helpers/pull/181/graphs/tree.svg?width=650&height=150&src=pr&token=onefg3YI04&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange)](https://codecov.io/gh/larmarange/broom.helpers/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) ```diff @@ Coverage Diff @@ ## main #181 +/- ## ========================================== + Coverage 97.34% 98.70% +1.35% ========================================== Files 38 38 Lines 1694 1695 +1 ========================================== + Hits 1649 1673 +24 + Misses 45 22 -23 ``` | [Impacted Files](https://codecov.io/gh/larmarange/broom.helpers/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) | Coverage Δ | | |---|---|---| | [R/assert\_package.R](https://codecov.io/gh/larmarange/broom.helpers/pull/181/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui9hc3NlcnRfcGFja2FnZS5S) | `94.02% <100.00%> (+34.93%)` | :arrow_up: |
larmarange commented 2 years ago

The checks failed with R 3.6 on Windows but it could be due to the fact that the remotes version of purrr is not available.

We need to re-check once the Remotes filed removed from DESCRIPTION.

larmarange commented 2 years ago

Thanks. Let me remove the Remotes from the DESCRIPTION, re-run all checks and then merge.

We may submit a new version on CRAN just after, what do you think?

ddsjoberg commented 2 years ago

We may submit a new version on CRAN just after, what do you think?

I looked in the purrr code and it seems to be a soft deprecation, meaning that warnings only appear in dev environments. So I don't there is any rush to release before their purrr 1.0 release

larmarange commented 2 years ago

It could be a problem for purrr team as CRAN will run a revdep check.