search

larmarange / broom.helpers

A set of functions to facilitate manipulation of tibbles produced by broom
https://larmarange.github.io/broom.helpers/
GNU General Public License v3.0
21 stars 8 forks source link

Required change to stay on CRAN #225

Closed larmarange closed 1 year ago

larmarange commented 1 year ago

A recent PR (https://bugs.r-project.org/show_bug.cgi?id=18548) showed that whereas version inputs to numeric_version() and package_version() were always documented to be "suitable character vectors" (or numeric vesion objects), the implementation also accepted numeric inputs via as.character() coercion, the results of which however are (at least currently) dependent on the setting of the OutDec option. Given that numeric input is certainly error-prone, imagine

as.numeric_version(1.20) as.numeric_version(1.5-1)

R Core has decided it would be best to gradually phase out such inputs.

Thus, With c84610 R-devel now warns about such inputs, which will typically not show in the check results (but immediately giving errors would cause too much disruption). Some of these warnings can be found by code analyis. I list these uses below, can you please fix as necessary? E.g., for the first issue shown,

packageVersion("ggplot2") >= 3.3

should be changed to

packageVersion("ggplot2") >= "3.3"

etc.

When doing so, please check the check outputs for such warnings, e.g. by

grep -r 'invalid non-character version specification' PKGNAME.Rcheck

One can for now set env var _R_CALLS_INVALID_NUMERICVERSION to something non-empty to get the call stacks for the warnings.

Please use a current version of R-devel for checking.

Please correct before 2023-08-16 to safely retain your package on CRAN.

Please note that CRAN will be closed for submissions between 2023-07-21 2023-08-08.

Best -k

$broom.helpers
$broom.helpers$`broom.helpers/inst/doc/tidy.R`
$broom.helpers$`broom.helpers/inst/doc/tidy.R`[[1]]
packageVersion("rmarkdown") >= 1.2

$broom.helpers$`broom.helpers/tests/testthat/test-add_coefficients_type..R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_coefficients_type..R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-add_contrasts.R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_contrasts.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-add_estimate_to_reference_rows.R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_estimate_to_reference_rows.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-add_n.R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_n.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-add_term_labels.R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_term_labels.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-add_variable_labels.R`
$broom.helpers$`broom.helpers/tests/testthat/test-add_variable_labels.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-identify_variables.R`
$broom.helpers$`broom.helpers/tests/testthat/test-identify_variables.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-model_get_n.R`
$broom.helpers$`broom.helpers/tests/testthat/test-model_get_n.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-tidy_plus_plus.R`
$broom.helpers$`broom.helpers/tests/testthat/test-tidy_plus_plus.R`[[1]]
packageVersion("geepack") < 1.3

$broom.helpers$`broom.helpers/tests/testthat/test-tidy_plus_plus.R`[[2]]
packageVersion("brms") < 2.13