search

larmarange / broom.helpers

A set of functions to facilitate manipulation of tibbles produced by broom
https://larmarange.github.io/broom.helpers/
GNU General Public License v3.0
21 stars 8 forks source link

new `tidy_post_fun` argument in `tidy_plus_plus()` #236

Closed larmarange closed 1 year ago

larmarange commented 1 year ago

fix #235

ddsjoberg commented 1 year ago

@larmarange I think that can be helpful for users!

Do you think we should pass anything else to post_fun()? the model object? that could be helpful, but does make the function a little trickier to specify because it should accept ... for whatever we choose to pass to it.

larmarange commented 1 year ago

At that stage of tidy_plus_plus(), the model is still attached as an attribute of the tibble

larmarange commented 1 year ago

So you could use tidy_get_model() if needed

ddsjoberg commented 1 year ago

fantastic! looks great!

codecov[bot] commented 1 year ago

Codecov Report

Merging #236 (d2966a4) into main (cef1f5f) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/larmarange/broom.helpers/pull/236/graphs/tree.svg?width=650&height=150&src=pr&token=onefg3YI04&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange)](https://app.codecov.io/gh/larmarange/broom.helpers/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) ```diff @@ Coverage Diff @@ ## main #236 +/- ## ======================================= Coverage 95.48% 95.48% ======================================= Files 43 43 Lines 2677 2679 +2 ======================================= + Hits 2556 2558 +2 Misses 121 121 ``` | [Files Changed](https://app.codecov.io/gh/larmarange/broom.helpers/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange) | Coverage Δ | | |---|---|---| | [R/tidy\_plus\_plus.R](https://app.codecov.io/gh/larmarange/broom.helpers/pull/236?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+Larmarange#diff-Ui90aWR5X3BsdXNfcGx1cy5S) | `100.00% <100.00%> (ø)` | |