`tidy_add_reference_rows()` erroneously adds reference row to interaction-only model

[ddsjoberg]

library(broom.helpers)
library(gtsummary)
#> #BlackLivesMatter

lm(age ~ factor(response):marker, trial) %>%
  tidy_and_attach() %>%
  tidy_identify_variables() %>%
  tidy_add_reference_rows() %>%
  knitr::kable()

term	variable	var_class	var_type	contrasts	reference_row	estimate	std.error	statistic	p.value
(Intercept)	NA	NA	intercept	NA	NA	46.6357738	1.632164	28.5729753	0.0000000
factor(response)0:marker	factor(response):marker	NA	interaction	NA	NA	0.3957856	1.507993	0.2624585	0.7932857
factor(response)1:marker	factor(response):marker	NA	interaction	NA	NA	0.1015807	1.653558	0.0614316	0.9510877
factor(response)0	factor(response)	NA	NA	NA	TRUE	NA	NA	NA	NA

^{Created on 2020-09-03 by the reprex package (v0.3.0)}

[larmarange]

tested added and fixed

[larmarange]

Thanks for all these checks

[ddsjoberg]

WOW! So fast!

I have so many unit tests written for tbl_regression already, and I am just re-purposing them for broom.helpers! 😆 There are so many different scenarios....it took a long time to address all these edge cases.

I am so excited for the package! Thank you for your amazing work on it!

[ddsjoberg]

FYI, I finished integrating broom.helpers into gtsummary and ran all the checks. It looks like everything is working perfectly! https://github.com/ddsjoberg/gtsummary/pull/606

Thanks for taking the time to write the awesome package! 🥇 You've made gtsummary more robust, and simplified the internals significantly. 💯

Once broom.helpers is on CRAN, I'll ask someone from my team to do more checking and merge the updates! Hopefully, the first CRAN submission comes back with a small nit-picky change so the re-submission incorporates the updates from the last few days! 🕺 🕺 🕺

[larmarange]

Let's see

I just resubmitted version 1.0.0 as I didn't have feedback yet from CRAN

🤞

Thanks for your feedback and all the new additional checks

[ddsjoberg]

It looks like it's a bit backed up with new submissions. Hopefully, there isn't something going on with the system.

https://lockedata.github.io/cransays/articles/dashboard.html

On Fri, Sep 4, 2020, 4:25 AM Joseph notifications@github.com wrote:

Let's see

I just resubmitted version 1.0.0 as I didn't have feedback yet from CRAN

🤞

Thanks for your feedback and all the new additional checks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/larmarange/broom.helpers/issues/43#issuecomment-687004672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGMIZHCXY6QHL4BHAX73VFLSECP7PANCNFSM4QUVX6FQ .