search

larpix / larpix-control

Control the LArPix chip
Other
4 stars 12 forks source link

Modified enable_miso/mosi register or config calls in controller.py to enable_piso/posi #246

Closed mualem closed 2 years ago

mualem commented 3 years ago

to make more compatible with v2b registers. Only enable_miso_differential remained unchanged, as it is the only one that does not have an analog in the v2b config. All others changed enable_m became enable_p.

mualem commented 3 years ago

If it's not obvious. This change would break any v2 asic config using init_network and possibly other methods as well, since there are not enable_piso/posi registers for v<2b

peter-madigan commented 3 years ago

@mualem @russellphysics Can you test this to make sure it works with both v2 and v2b?

mualem commented 3 years ago

Looks like some progress. The new versions work with my version2 code. I still have problems with v2b, but I made quite a few changes while trying to debug, so I might still have some bad config in there. For example, my v2 code was broken since I had to force differential=False so it would avoid the nonexistent enable_piso_differential for v2b.

I'll poke at it some more now, and maybe we can discuss a little later.

Leon Mualem Lauritsen Lab MC 356-48 Caltech 1200 E. California Blvd. Pasadena, CA 91125 1 (626) 817-3459

From: peter-madigan @.> Sent: Monday, September 27, 2021 10:29 AM To: larpix/larpix-control @.> Cc: Mualem, Leon @.>; Mention @.> Subject: Re: [larpix/larpix-control] Modified enable_miso/mosi register or config calls in controller.py to enable_piso/posi (#246)

@mualemhttps://github.com/mualem @russellphysicshttps://github.com/russellphysics Can you test this to make sure it works with both v2 and v2b?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/larpix/larpix-control/pull/246#issuecomment-928096164, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEN5E7Z5NNK3REVT4C5CEQLUECSY5ANCNFSM5E23E2GQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

peter-madigan commented 3 years ago

@mualem #248 should fix the issues you were having with init_network