Fix clang arc weak enabled

larpon / QtFirebase

An effort to bring Google's Firebase C++ API to Qt + QML

MIT License

284 stars 83 forks source link

Fix clang arc weak enabled #101

Closed clayly closed 5 years ago

clayly commented 5 years ago

Fixes error if xcode options CLANG_ENABLE_OBJC_WEAK=YES CLANG_ENABLE_OBJC_ARC=YES is added to xcode build settings. This options is needed to use modern Objective-C with automatic memory management.

larpon commented 5 years ago

"Not there ll be no error if xcode options" <- This is unclear to me? What does this fix?

clayly commented 5 years ago

"Not there ll be no error if xcode options" <- This is unclear to me? What does this fix?

Just a typo ). If someone will link to your library and also will link to modern Objective-C code which uses automatic reference count (ARC), there will be compile error without this fix.

larpon commented 5 years ago

Ah! Awesome! Thanks!