search

larpon / QtFirebase

An effort to bring Google's Firebase C++ API to Qt + QML
MIT License
284 stars 83 forks source link

Add support for arm64-v8a #102

Closed MasterMind2k closed 5 years ago

MasterMind2k commented 5 years ago

With Qt 5.12 we got builds for arm64-v8a.

When trying to build my project with QtFirebase I received a lot of "ambiguous" compiler errors coupled with implicit conversions warnings (all together 47).

larpon commented 5 years ago

This is only possible if Google has (or adds) support for this architecture. Try raising an issue here and see what they say

khoaopentechiz commented 5 years ago

hi @Larpon what do you mean by google support for this architecture? do you mean in order to build a qt app that has QtFirebase for arm64, the firebase c++ sdk should support this architecture?

larpon commented 5 years ago

@MasterMind2k + @khoaopentechiz Sorry - my bad - I had a old SDK confusing me. I guess it should work then. @MasterMind2k could you maybe paste a few essential lines from the error you're getting to get us started? It could be something simple like a wrong ARCH define somewhere.

@khoaopentechiz I can see in the sdk <sdk root>/libs/android/ that there's pre-compiled libs for arm64-v8a - so unless they're broken it should work out of the box

MasterMind2k commented 5 years ago

Some lines:

/QtFirebase/src/qtfirebaseservice.cpp:185:20: error: ambiguous conversion for functional-style cast from 'int64_t' (aka 'long') to 'QVariant'

/QtFirebase/src/qtfirebaseremoteconfig.cpp:230:45: error: use of overloaded operator '=' is ambiguous (with operand types 'QVariant' and 'int64_t' (aka 'long'))
                updatedParameters[it.key()] = remote_config::GetLong(it.key().toUtf8().constData());
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

But, simply by building with latest Qt 5.12.3 against latest Android NDK, you should get these errors.

MasterMind2k commented 5 years ago

Oh, and yes. You need to use the clang compiler! The gnustl won't work anymore.

larpon commented 5 years ago

Closing this as I get no compile errors after this commit.