search

larpon / QtFirebase

An effort to bring Google's Firebase C++ API to Qt + QML
MIT License
284 stars 83 forks source link

Code cleanup #56

Closed demiantres closed 6 years ago

demiantres commented 6 years ago

Improvements:

larpon commented 6 years ago

@demiantres - thanks! A good idea with the base classes. I've skimmed your changes and they look fine. I'll have to check if everything is working in the example app (both Android + iOS) - and then merge if everything runs :)

demiantres commented 6 years ago

I have tested all the Admob ad types in iOS and here they work fine (but four eyes see more than two ;)).

demiantres commented 6 years ago

I have submitted another patch which now uses async for the Admob stuff.