larpon / QtFirebase

An effort to bring Google's Firebase C++ API to Qt + QML
MIT License
284 stars 83 forks source link

Make `future.OnCompletion` threadsafe #82

Closed Sharm closed 6 years ago

Sharm commented 6 years ago
- Fixed QObject::killTimer: timers cannot be stopped from another thread
- Fixed another potential issues with threads
larpon commented 6 years ago

@Sharm these changes causes issues with older Qt versions see #84 . Any chance you could provide a fix? I'll have to revert the changes otherwise to not break compability with older versions

Sharm commented 6 years ago

It possible to fix by introduce additional functions to invoke. A lot of new functions...it will looks ugly. Now it so clear as with lambdas.