search

larray-project / larray-editor

Graphical User Interface for LArray
GNU General Public License v3.0
2 stars 2 forks source link

(issue 165) remember size of main window and internal components #191

Closed alixdamman closed 5 years ago

gdementen commented 5 years ago

One more thing: remember most of (all in this case) my review comments are suggestions of how I think we could do better. You are free to disagree that it is actually better (and don't need to explain why).

alixdamman commented 5 years ago

In one of your previous comment:

Could you explain me why you need this two-step process (ie add widgets to a dict and then traverse that dict) instead of doing that in a "get_widgets_with_state_to_restore" method?

I am not sure of how to implement the "get_widgets_with_state_to_restore()" method? Is it a method that needs to be override in subclasses manually or a more general method that will dig into the main and sub layouts to detect all widgets with a saveState() method?

gdementen commented 5 years ago

I am not sure of how to implement the "get_widgets_with_state_to_restore()" method? Is it a method that needs to be override in subclasses manually or a more general method that will dig into the main and sub layouts to detect all widgets with a saveState() method?

As I said above, forget about it. I meant the manual subclass override but what you have now is simpler anyway.

alixdamman commented 5 years ago

OK to merge?

gdementen commented 5 years ago

LGTM (modulo history cleanup of course), nice work!