larray-project / larray-editor

Graphical User Interface for LArray
GNU General Public License v3.0
2 stars 2 forks source link

Avoid "from larray import *" #199

Closed gdementen closed 2 years ago

gdementen commented 4 years ago

As a follow-up to what I tried to do in #198, we need to avoid polluting the console namespace by doing "from larray import *" when calling the viewer using view()/edit() or debug().

Explanation why this is needed is at: https://github.com/larray-project/larray-editor/pull/198#issuecomment-544425855

The reason why I didn't merge the change I did initially is that (as Alix explained), that behaviour is sometimes desirable outside of the standalone viewer (e.g. when doing view(session)). And I think, it should be done along with reset() for example after new(), etc. So the circumstance where it is actually needed or not need to be thought through.