Open gdementen opened 2 years ago
I stumbled on this again and see really no valid reason not to support this. I am unsure about deprecating the names argument and the list/tuple of objects syntax. I think it would be better but is it worth "breaking" (at first it would just be a warning) backward compatibility? I don't know. Anyway, this could come later.
I also think we should start with a warning (and an issue to not forget to deprecate the names argument in the (short) future).
Deprecating the *args and names argument seems like a bad idea because it makes it impossible to compare arrays with the same name (see #247).
I just had to compare many sessions and naturally put them in a dict of sessions, then wanted to compare them and tried
compare(dict_of_sessions)
but it does not work (compare(dict_of_arrays)
does not work either) but the workaround felt very clunky:On the other hand, I know that forever expanding the API is not a good idea, but I see this akin to what we support for rename, set_labels etc.
Maybe we should deprecate the names= argument of compare (and possibly even the *args syntax) and instead replace it with:
which we could thus call either: