search

larray-project / larray

N-dimensional labelled arrays in Python
https://larray.readthedocs.io/
GNU General Public License v3.0
8 stars 6 forks source link

Better document fill_value argument of read_*() #1020

Closed alixdamman closed 1 year ago

alixdamman commented 1 year ago

Reported by user GT.

He got nan instead of 0 although passed fill_value=0 to read_excel().

gdementen commented 1 year ago

I cannot reproduce this. I need a reproducer to be able to fix it.

FWIW, we have a test case for this at: https://github.com/larray-project/larray/blob/master/larray/tests/test_array.py#L3402 https://github.com/larray-project/larray/blob/master/larray/tests/test_array.py#L3425 and the corresponding tests when using openpyxl: https://github.com/larray-project/larray/blob/master/larray/tests/test_array.py#L3468

gdementen commented 1 year ago

(I am going to ask gt)

gdementen commented 1 year ago

In fact, there was no bug at all: just a misunderstanding of what fill_value does.

gdementen commented 1 year ago

will change the meaning of the argument in #1028 instead of changing the documentation