search

larray-project / larray

N-dimensional labelled arrays in Python
https://larray.readthedocs.io/
GNU General Public License v3.0
8 stars 6 forks source link

Finalize add of return type hints #979

Closed alixdamman closed 3 years ago

alixdamman commented 3 years ago

@gdementen I wonder if we shouldn't either define [L|I]GroupKey types in types.py or even make them classes (there are a lot of private functions in group.py ?

gdementen commented 3 years ago

@gdementen I wonder if we shouldn't either define [L|I]GroupKey types in types.py or even make them classes (there are a lot of private functions in group.py ?

Sorry, I don't understand what you mean.

alixdamman commented 3 years ago

@gdementen could you review the last pushed commit (added type Key: 0dac948d977f87d01c3844b9f24bc5ef7ae6a8f4 ) ?

gdementen commented 3 years ago

@gdementen could you review the last pushed commit (added type Key: 0dac948 ) ?

Except for the failed test & test warnings, this LGTM

alixdamman commented 3 years ago

Thanks for the review