Closed alixdamman closed 3 years ago
@gdementen I wonder if we shouldn't either define [L|I]GroupKey types in types.py or even make them classes (there are a lot of private functions in group.py ?
Sorry, I don't understand what you mean.
@gdementen could you review the last pushed commit (added type Key: 0dac948d977f87d01c3844b9f24bc5ef7ae6a8f4 ) ?
@gdementen could you review the last pushed commit (added type Key: 0dac948 ) ?
Except for the failed test & test warnings, this LGTM
Thanks for the review
@gdementen I wonder if we shouldn't either define [L|I]GroupKey types in types.py or even make them classes (there are a lot of private functions in group.py ?