larry-robotics / elkodon

Elkodon - true zero-copy inter-process-communication in rust
Apache License 2.0
14 stars 2 forks source link

elk-3 add log and tracing logger #63

Closed elfenpiff closed 7 months ago

elfenpiff commented 7 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked
  4. [x] Every source code file has the SPDX header SPDX-License-Identifier: $(LICENSE_CODE)
  5. [x] Branch follows the naming format (elk-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #3

codecov[bot] commented 7 months ago

Codecov Report

Merging #63 (a6a07cf) into main (b4dd0e0) will increase coverage by 0.72%. The diff coverage is 75.39%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/elkodon/elkodon/pull/63/graphs/tree.svg?width=650&height=150&src=pr&token=57QN0YX5DJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon)](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) ```diff @@ Coverage Diff @@ ## main #63 +/- ## ========================================== + Coverage 77.19% 77.91% +0.72% ========================================== Files 169 172 +3 Lines 18910 19036 +126 ========================================== + Hits 14597 14832 +235 + Misses 4313 4204 -109 ``` | [Files](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) | Coverage Δ | | |---|---|---| | [elkodon/src/config.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvY29uZmlnLnJz) | `66.32% <100.00%> (+0.34%)` | :arrow_up: | | [elkodon/src/port/details/publisher\_connections.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9kZXRhaWxzL3B1Ymxpc2hlcl9jb25uZWN0aW9ucy5ycw==) | `87.01% <ø> (+1.29%)` | :arrow_up: | | [elkodon/src/port/details/subscriber\_connections.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9kZXRhaWxzL3N1YnNjcmliZXJfY29ubmVjdGlvbnMucnM=) | `94.73% <ø> (+1.75%)` | :arrow_up: | | [elkodon/src/port/listener.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9saXN0ZW5lci5ycw==) | `55.40% <ø> (ø)` | | | [elkodon/src/port/notifier.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9ub3RpZmllci5ycw==) | `80.46% <ø> (ø)` | | | [elkodon/src/port/publisher.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9wdWJsaXNoZXIucnM=) | `80.56% <ø> (-0.60%)` | :arrow_down: | | [elkodon/src/service/builder/mod.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvc2VydmljZS9idWlsZGVyL21vZC5ycw==) | `82.24% <ø> (ø)` | | | [elkodon/src/service/mod.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvc2VydmljZS9tb2QucnM=) | `70.92% <100.00%> (-6.07%)` | :arrow_down: | | [elkodon/src/service/naming\_scheme.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvc2VydmljZS9uYW1pbmdfc2NoZW1lLnJz) | `100.00% <100.00%> (ø)` | | | [elkodon\_bb/log/src/lib.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbl9iYi9sb2cvc3JjL2xpYi5ycw==) | `50.00% <ø> (ø)` | | | ... and [23 more](https://app.codecov.io/gh/elkodon/elkodon/pull/63?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) | | ... and [37 files with indirect coverage changes](https://app.codecov.io/gh/elkodon/elkodon/pull/63/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon)