search

larry-robotics / elkodon

Elkodon - true zero-copy inter-process-communication in rust
Apache License 2.0
16 stars 2 forks source link

Elk 3 switch license #68

Closed elfenpiff closed 9 months ago

elfenpiff commented 9 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked
  4. [x] Every source code file has the SPDX header SPDX-License-Identifier: $(LICENSE_CODE)
  5. [x] Branch follows the naming format (elk-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #ISSUE-NUMBER

codecov[bot] commented 9 months ago

Codecov Report

Merging #68 (3c856ff) into main (346ba62) will not change coverage. Report is 4 commits behind head on main. The diff coverage is 75.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/elkodon/elkodon/pull/68/graphs/tree.svg?width=650&height=150&src=pr&token=57QN0YX5DJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon)](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) ```diff @@ Coverage Diff @@ ## main #68 +/- ## ======================================= Coverage 77.88% 77.88% ======================================= Files 172 172 Lines 19059 19059 ======================================= Hits 14845 14845 Misses 4214 4214 ``` | [Files](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) | Coverage Δ | | |---|---|---| | [elkodon/src/config.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvY29uZmlnLnJz) | `66.32% <ø> (ø)` | | | [elkodon/src/elk.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvZWxrLnJz) | `0.00% <ø> (ø)` | | | [elkodon/src/message.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvbWVzc2FnZS5ycw==) | `0.00% <ø> (ø)` | | | [elkodon/src/port/details/publisher\_connections.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9kZXRhaWxzL3B1Ymxpc2hlcl9jb25uZWN0aW9ucy5ycw==) | `87.01% <ø> (ø)` | | | [elkodon/src/port/details/subscriber\_connections.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9kZXRhaWxzL3N1YnNjcmliZXJfY29ubmVjdGlvbnMucnM=) | `94.73% <ø> (ø)` | | | [elkodon/src/port/event\_id.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9ldmVudF9pZC5ycw==) | `100.00% <ø> (ø)` | | | [elkodon/src/port/listener.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9saXN0ZW5lci5ycw==) | `55.40% <ø> (ø)` | | | [elkodon/src/port/mod.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9tb2QucnM=) | `0.00% <ø> (ø)` | | | [elkodon/src/port/notifier.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9ub3RpZmllci5ycw==) | `80.46% <ø> (ø)` | | | [elkodon/src/port/port\_identifiers.rs](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon#diff-ZWxrb2Rvbi9zcmMvcG9ydC9wb3J0X2lkZW50aWZpZXJzLnJz) | `88.88% <ø> (ø)` | | | ... and [149 more](https://app.codecov.io/gh/elkodon/elkodon/pull/68?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon) | | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/elkodon/elkodon/pull/68/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=elkodon)