search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
569 stars 278 forks source link

fix: lookup url by id not sending all params #227

Closed humanolaranja closed 2 years ago

humanolaranja commented 2 years ago

languageCode was not working as expected, debbuged and find the problem

Sorry for that, but it's a simple fix @larryaasen

codecov[bot] commented 2 years ago

Codecov Report

Base: 93.01% // Head: 93.02% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (298dc9d) compared to base (8b24fb0). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #227 +/- ## ======================================= Coverage 93.01% 93.02% ======================================= Files 10 10 Lines 959 960 +1 ======================================= + Hits 892 893 +1 Misses 67 67 ``` | [Impacted Files](https://codecov.io/gh/larryaasen/upgrader/pull/227?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen) | Coverage Δ | | |---|---|---| | [lib/src/play\_store\_search\_api.dart](https://codecov.io/gh/larryaasen/upgrader/pull/227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen#diff-bGliL3NyYy9wbGF5X3N0b3JlX3NlYXJjaF9hcGkuZGFydA==) | `96.93% <100.00%> (ø)` | | | [lib/src/upgrader.dart](https://codecov.io/gh/larryaasen/upgrader/pull/227/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen#diff-bGliL3NyYy91cGdyYWRlci5kYXJ0) | `90.18% <100.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

larryaasen commented 2 years ago

@humanolaranja This looks good, and thanks for the fix. Also, the CLI should be updated as well: https://github.com/larryaasen/upgrader/blob/master/bin/playstore_lookup.dart