larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
547 stars 268 forks source link

'he' locale message missing closing bracket '}' #236

Closed lielvan closed 1 year ago

lielvan commented 1 year ago
I/flutter (18122): upgrader: languageCode: he
I/flutter (18122): upgrader: operatingSystem: android
I/flutter (18122): upgrader: platform: TargetPlatform.android
I/flutter (18122): upgrader: isAndroid: true, isIOS: false, isLinux: false, isMacOS: false, isWindows: false, isFuchsia: false, isWeb: false
I/flutter (18122): upgrader: package info version: 3.7.71
I/flutter (18122): upgrader: countryCode: US
I/flutter (18122): upgrader: languageCode: en
Reloaded 1 of 2735 libraries in 439ms (compile: 37 ms, reload: 213 ms, reassemble: 171 ms).
I/flutter (18122): upgrader: blocked: false
I/flutter (18122): upgrader: debugDisplayAlways: true
I/flutter (18122): upgrader: debugDisplayOnce: false
I/flutter (18122): upgrader: hasAlerted: false
I/flutter (18122): upgrader: shouldDisplayUpgrade: true
I/flutter (18122): UpgradeCard: will display
I/flutter (18122): UpgradeCard: showDialog title: לעדכן יישומון?
I/flutter (18122): UpgradeCard: showDialog message: גרסה חדשה של קיימת! גרסה 3.7.68 ניתנת להורדה-יש לך גרסה {{currentInstalledVersion}.
  upgrader:
    dependency: "direct main"
    description:
      name: upgrader
      url: "https://pub.dartlang.org"
    source: hosted
    version: "4.11.0"

Seems the case for 'he' locale is missing a closing bracket for the variable currentInstalledVersion in upgrade_messages.dart line 150.

larryaasen commented 1 year ago

I see that and thanks for pointing that out. It can easily be fixed.

larryaasen commented 1 year ago

It is not fixed on the main branch. It will go out in the next release.

larryaasen commented 1 year ago

Released in 4.11.1