larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
547 stars 268 forks source link

Release notes on android appears in single line only #239

Closed OutdatedGuy closed 1 year ago

OutdatedGuy commented 1 year ago

I have an issue for android upgrader. On android the release notes are all set as a single line. But on the developer page it is set as multiline.

I want to know how can I make release notes on android similar to the ones on ios.


On android upgrader alert:

image

On playstore page:

image

Android Upgrader debug logs:

I/flutter ( 7175): upgrader: platform: TargetPlatform.android
I/flutter ( 7175): upgrader: isAndroid: true, isIOS: false, isLinux: false, isMacOS: false, isWindows: false, isFuchsia: false, isWeb: false
I/flutter ( 7175): upgrader: package info packageName: com.club5am.app
I/flutter ( 7175): upgrader: package info appName: 5amClub
I/flutter ( 7175): upgrader: package info version: 1.6.0
I/flutter ( 7175): upgrader: countryCode: US
I/flutter ( 7175): upgrader: languageCode: en
I/flutter ( 7175): upgrader: blocked: false
I/flutter ( 7175): upgrader: debugDisplayAlways: true
I/flutter ( 7175): upgrader: debugDisplayOnce: false
I/flutter ( 7175): upgrader: hasAlerted: false
I/flutter ( 7175): upgrader: shouldDisplayUpgrade: true
I/flutter ( 7175): upgrader: shouldDisplayReleaseNotes: true
I/flutter ( 7175): upgrader: showDialog title: Update App?
I/flutter ( 7175): upgrader: showDialog message: A new version of 5amClub is available! Version 2.0.0 is now available-you have 1.6.0.
I/flutter ( 7175): upgrader: showDialog releaseNotes: - Added poppins google fonts as default text style.- Fixed profile photo alignment in profile page.- Added website link to register to campaign.

On ios upgrader alert:

image

On appstore page:

image

iOS Upgrader debug logs:

flutter: upgrader: build UpgradeAlert
flutter: upgrader: languageCode: en
flutter: upgrader: default operatingSystem: ios Version 16.1 (Build 20B72)
flutter: upgrader: operatingSystem: ios
flutter: upgrader: platform: TargetPlatform.iOS
flutter: upgrader: isAndroid: false, isIOS: true, isLinux: false, isMacOS: false, isWindows: false, isFuchsia: false, isWeb: false
flutter: upgrader: package info packageName: com.club5am.app
flutter: upgrader: package info appName: 5amClub
flutter: upgrader: package info version: 1.6.0
flutter: upgrader: countryCode: US
flutter: upgrader: languageCode: en
flutter: upgrader: blocked: false
flutter: upgrader: debugDisplayAlways: true
flutter: upgrader: debugDisplayOnce: false
flutter: upgrader: hasAlerted: false
flutter: upgrader: shouldDisplayUpgrade: true
flutter: upgrader: shouldDisplayReleaseNotes: true
flutter: upgrader: showDialog title: Update App?
flutter: upgrader: showDialog message: A new version of 5amClub is available! Version 2.0 is now available-you have 1.6.0.
flutter: upgrader: showDialog releaseNotes: - Added poppins google fonts as default text style.
- Fixed profile photo alignment in profile page.
- Added website link to register to campaign.

Upgrader version:

upgrader:
  dependency: "direct main"
  description:
    name: upgrader
    url: "https://pub.dartlang.org"
  source: hosted
  version: "5.0.0"
JaviGaiax commented 1 year ago

Same thing here. Any reason for this?

edit: after looking more into it, in my case, the problem seems to be here

static String? multilineReleaseNotes( String innerHtml, Element rawReleaseNotes) { String? releaseNotes;

if (releaseNotesSpan.hasMatch(innerHtml)) {

where releaseNotesSpan is looking for a <span> tag but you can't manually put it in the developer console nor it is automatically added to the html code in the website

larryaasen commented 1 year ago

I created PR #257 to address this issue.

larryaasen commented 1 year ago

This PR was released in version 5.1.0 today.

OutdatedGuy commented 1 year ago

@larryaasen, working properly now, thanks 🚀

larryaasen commented 1 year ago

@JaviGaiax ^^^