search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
547 stars 268 forks source link

Make sure initialization errors is not ignored #241

Closed joymyr closed 7 months ago

joymyr commented 1 year ago

On Android willDisplayUpgrade is not called at all when there's no network, e.g. when launching the app in flight mode. So the app is stuck if it depends on this callback to continue. For some reason this doesn't happen on iOS. Adding an error handler to the initialize method makes the behaviour consistent between Android and iOS, and it could potentially catch other errors on both platforms.

larryaasen commented 1 year ago

@joymyr In airplane mode I see initialized completing. Is this still an issue for you?

larryaasen commented 7 months ago

@joymyr Is this still an issue for you?

joymyr commented 7 months ago

@larryaasen No, I'm not seeing this issue anymore

larryaasen commented 7 months ago

Since you are not seeing this anymore, I'm closing this.