search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
547 stars 268 forks source link

fix: strict null safety, and doesn't render when message is `null` #246

Closed cipchk closed 8 months ago

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1238f62) 93.07% compared to head (24a4dc6) 93.08%. Report is 139 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #246 +/- ## ========================================== + Coverage 93.07% 93.08% +0.01% ========================================== Files 10 10 Lines 967 969 +2 ========================================== + Hits 900 902 +2 Misses 67 67 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cipchk commented 1 year ago

Hi, @larryaasen Can you review it? We need it.

larryaasen commented 1 year ago

This is a good PR but there is a lot to review here. Need more time.

larryaasen commented 1 year ago

@cipchk Can you provide an example of this issue?

larryaasen commented 8 months ago

This PR cannot be merged. Either make a smaller PR or close this.