search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
567 stars 273 forks source link

Do critical update if current app version is smaller than latest critical update version #248

Closed luiges90 closed 1 year ago

luiges90 commented 1 year ago

This PR fixes an issue when the appcast contains both critical updates and regular updates, and critical update version is lower than the regular update version, Apps lower than critical version fails to act as a critical update. i.e. Suppose critical update version is 0.13.0, regular update version is 0.14.0. If app version is 0.12.0, it offers update to 0.14.0 but the Ignore / Later buttons still show. After this PR, upgrader should offer update to 0.14.0 and do not show the Ignore / Later buttons.

ahmet-fennel commented 1 year ago

This is really useful can we get this merged.

larryaasen commented 1 year ago

@luiges90 Thanks for this PR and it looks very useful. However, it is missing unit tests. Can those be added?

ahmet-fennel commented 1 year ago

I've created the PR here https://github.com/larryaasen/upgrader/pull/275 which is a fork of this branch i'll try to resolve conflicts and add tests