larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
567 stars 273 forks source link

Fix japanese translation #265

Closed K9i-0 closed 1 year ago

K9i-0 commented 1 year ago

? was unnatural in the Japanese sense, so it was removed.

It looks like it was added unintentionally in the commit below. https://github.com/larryaasen/upgrader/commit/52938cb4e3473c1898b278fc0be028ee18599606

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.06% // Head: 93.06% // No change to project coverage :thumbsup:

Coverage data is based on head (21ebd11) compared to base (92f2919). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #265 +/- ## ======================================= Coverage 93.06% 93.06% ======================================= Files 10 10 Lines 980 980 ======================================= Hits 912 912 Misses 68 68 ``` | [Impacted Files](https://codecov.io/gh/larryaasen/upgrader/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen) | Coverage Δ | | |---|---|---| | [lib/src/upgrade\_messages.dart](https://codecov.io/gh/larryaasen/upgrader/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen#diff-bGliL3NyYy91cGdyYWRlX21lc3NhZ2VzLmRhcnQ=) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Larry+Aasen)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

larryaasen commented 1 year ago

@K9i-0 Thanks for this PR. I will merge it now.