Closed ahmet-fennel closed 6 months ago
@larryaasen i'll work on the tests but can you let me know if this is a change we can get merged
@ahmet-fennel The current upgrader package does not support multiple enclosure tags in an Appcast item. There is no supporting documentation that suggests that multiple enclosures should be supported. According to https://sparkle-project.org/documentation/publishing/ and https://sparkle-project.org/documentation/api-reference/Classes/SUAppcastItem.html there is no indication that multiple enclosure tags are supported.
To get around this, just use multiple items with different sparkle:os tags.
This PR solves two different issues that we encountered during the integration of this plugin.
Example Appcast:
So even if the application is running on android it currently chooses the appstore link.
This raises one minor issue:
If the current app version is 1.0.0, and the appcast contains 1.2.0 as a critical update and 1.2.1 as a non-critical update
The pop-up appears as 1.2.1 is a required update and the user must update, even though the reason that the pop up can't be skipped is the 1.2.0 which is the required version.
This fixes by displaying the critical version (1.2.0) in the dialog instead of the latest (1.2.1)