search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
526 stars 260 forks source link

Pass the language code to iTunes search api to get localized release notes #351

Open Add00w opened 8 months ago

Add00w commented 8 months ago

fixes #314

larryaasen commented 7 months ago

@Add00w Thanks for this pull request. Did you see that the unit tests are not passing?

Add00w commented 7 months ago

@Add00w Thanks for this pull request. Did you see that the unit tests are not passing?

Yes, I will fix

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a8f9cad) 90.15% compared to head (c58a6e6) 90.27%. Report is 12 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #351 +/- ## ========================================== + Coverage 90.15% 90.27% +0.12% ========================================== Files 11 11 Lines 1066 1080 +14 ========================================== + Hits 961 975 +14 Misses 105 105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larryaasen commented 1 month ago

@Add00w I would like to get this PR merged, but it now has a merge conflict. Can you resolve that?