search

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.
MIT License
523 stars 258 forks source link

Fix #375 to correctly decode special characters in app titles. #376

Closed aruhant closed 3 months ago

aruhant commented 5 months ago

This is to fix playstore parsing when app name in playstore contains special characters like apostrophe, ampersand or other unicode characters.

I have tested the changes on the following page and it seems to work correctly: https://play.google.com/store/apps/details?id=com.mcdonalds.app

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dde6677) 90.27% compared to head (0373e14) 90.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #376 +/- ## ======================================= Coverage 90.27% 90.28% ======================================= Files 11 11 Lines 1080 1081 +1 ======================================= + Hits 975 976 +1 Misses 105 105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larryaasen commented 3 months ago

@aruhant Thanks for this PR. However, it does not contain a unit test. Without that, there is no way to show that this change actually fixes a problem. Can you add a unit test?

larryaasen commented 3 months ago

I fixed this issue and it will be available in the next release 10.1.0.

aruhant commented 3 months ago

Thank you. If you still need help with the unit test, I'll be happy to add one.