checkVersion - Githubissues

larryaasen / upgrader

A Flutter package for prompting users to upgrade when there is a newer version of the app in the store.

MIT License

523 stars 258 forks source link

checkVersion #391

Closed ktnishide closed 3 months ago

ktnishide commented 3 months ago

Upgrader checkVersion is removed? what is the alternative?

Upgrader version 9.0.0

thanks

larryaasen commented 3 months ago

I see checkVersion right here: https://github.com/larryaasen/upgrader/blob/76e31311b87c453cd4c230708e7bff2535932ad9/lib/src/upgrade_alert.dart#L134

ktnishide commented 3 months ago

Sorry, let me clarify.

We were using upgrader.checkVersion() to programmatically check and display alert when app return to foreground on Upgrader version 6.5.0 but now we realized the package implemented the feature.

Sorry for the misunderstanding.

vladchuk commented 1 month ago

I am still not quite clear on how to check version at will: checkVersion() is no longer on the Upgrader, but on AlertDialog state. What if I can't/don't want to inject the alert into my widget hierarchy?..

Unless I'm missing something, it looks like useful functionality was removed. Can you please explain?

vladchuk commented 1 month ago

I ended up bastardizing UpgradeAlert as follows:

make UpgradeAlert a plain class (not a widget)
conflate UpgradeAlertState with it, exposing checkVersion(), etc.
instantiate alert right after upgrader and use it as before (in v. 8.x.x)

All in all, this feels like a regression. Please consider bringing the original functionality back.