Open jordanwillis opened 6 years ago
Hi Jordan Thanks for the really positive feedback I really appreciate it!!! And thanks for pointing out that mistake with the value being greater than 1, I did notice it and it bothered me at the time but I felt a bit under pressure to get the assignment in as I am really short of time this week. It was a great project and the penny finally dropped (or at least got much closer to the ground) in terms of Classes and how they worked and why they were so useful so I feel really positive about that!! Thanks again Marcus
No worries, that pressure can unfortunately get in the way sometimes! The good thing is that it was just an omission mistake (e.g. you forgot to add the division) and not an implementation or coding mistake! 👍
Rubric Score
Criteria 1: Valid Python Code
Criteria 2: Implementation of Project Requirements
get_average_sentence_length
function (for example ? or !). Therefore, you should account for these in your logic as well like this.find_text_similarity
function before returning. Your current implementation is adding the 3 values together but not performing the division. The reason for the division is because we need to take an average of each of the different similarity scores.Criteria 3: Software Architecture
Criteria 4: Uses Python Language Features
prepare_data
implementation! I had not thought of that approach yet, plus one-liners that are easy to read and make sense are always slick.Criteria 5: Produces Accurate Output
find_text_similarity
. Here is what the correct answers were.If you think about it, we would not expect an answer to ever be greater than 1 because even if you compared the same text together, the best similarity score that they could have is 1 (e.g. 100%).
Overall Score: 18/20
Overall you did a fantastic job on this project and demonstrated that you learned a lot in this course! Keep up the great work!!