larryhastings / gilectomy

Gilectomy branch of CPython. Use "gilectomy" branch in git. Read the important, short README below!
Other
527 stars 43 forks source link

Update port to Windows #23

Open larryhastings opened 8 years ago

larryhastings commented 8 years ago

I just redid the platform abstraction. I tried to keep the Windows port going, but I don't have a Windows box handy so I can't test it. Please test and fix!

brianherman commented 8 years ago

You have a section where you included unistd.h so i put in this to fix that, I'll try to give you a patch tomorrow but it is an easy fix. Instead of just unistd.h you need:

ifdef _WIN32

#include <io.h>
#else
#include <unistd.h>
#endif

But I am getting this error when I build: This error also happens for every file that is in \Python..

    c:\users\brian\desktop\gilectomy\include\lock.h(210): warning C4013: 'pthread_equal' undefined;     assuming extern returning int [C:\Users\brian\Desktop\gilectomy\PCbuild\xxlimited.vcxproj]
    c:\users\brian\desktop\gilectomy\include\lock.h(203): warning C4047: 'initializing': 'threadid_t' differs in levels of indirection from 'unsigned long (__cdecl *)()' [C:\Users\brian\Desktop\gilectomy
\PCbuild\xxlimited.vcxproj]
     ..\Modules\xxlimited.c(306): error C2129: static function 'void py_nativelock_unlock(void **)'     declared but not defined [C:\Users\brian\Desktop\gilectomy\PCbuild\xxlimited.vcxproj]
     c:\users\brian\desktop\gilectomy\include\lock.h(73): note: see declaration of 'py_nativelock_unlock'