larrylawl / pe

0 stars 0 forks source link

Able to add a food item with expirty date that is before system clock #1

Open larrylawl opened 4 years ago

larrylawl commented 4 years ago

Describe the bug Able to add a food item with expirty date that is before system clock

To Reproduce Steps to reproduce the behavior:

  1. glist add n/Fuji apples e/30/10/1899 t/healthy a/10units

Actual behavior Fuji apples was added.

Expected behavior Exception should be thrown, stating that expiry date should not be before system clock. This is because a food item that is just added to the fridge should not be already expired.

Screenshots

Additional context Add any other context about the problem here.

nus-pe-bot commented 4 years ago

Team's Response

Thanks for the feedback.

We allow user to add items that have expired to allow for greater flexibility for the user. In some instances, the user may have unintentionally bought items that are expired and wishes to keep them due to various reasons (e.g. items can be useful for purposes other than consumption, items are not way past beyond its expiry date and may still be safe for consumption).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.High]. Originally [severity.Medium].

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.FeatureFlaw]. Originally [type.FunctionalityBug].

Reason for disagreement: [replace this with your reason]