Shopping list is not updated when grocery list is updated

[larrylawl]

Describe the bug Shopping list is not updated when item in shopping list is editted in the grocery list.

To Reproduce Steps to reproduce the behavior:

1. slist list (Beef should be partially bought there)
2. glist find Minced Beef
3. glist edit 1 n/Nasi Lemak

Actual behavior Minced Beef in shopping list still shows partially bought.

Expected behavior Minced Beef in shopping list should not have partially bought tag as your grocery list does not contain any minced beef.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

[nus-pe-bot]

Team's Response

Bought items of the shopping list have nothing to do with the grocery list.

Grocery list represents items that are in your fridge, while bought items represent shopping items that have been bought but not yet moved to the fridge.

This is why bought items are not immediately to the grocery list, there is a mergebought feature for that purpose.

This distinction is made clear by the existence of the mergebought feature and the description of the mergebought feature in the UG that mentions that the command "adds all items marked as ‘bought’ to the grocery list".

Hence editing bought shopping items when grocery items are edited would not be of value the user and would cause regressions.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: "Grocery list represents items that are in your fridge, while bought items represent shopping items that have been bought but not yet moved to the fridge."

Given the intended functionality of grocery and shopping list and consider the case I have mentioned under the sequence of steps, then missing Minced Beef in the fridge (ie grocery list) should not have the partially bought tag in the shopping list; the minced beef isn't even there.

"Hence editing bought shopping items when grocery items are edited would not be of value the user and would cause regressions."

Consider the scenario where the user thought that he/she has bought minced beef, thus the user used the mergebought feature to merge the purchase into the fridge. Minced Beef will have the partially bought tag. However, the user next realises that he/she bought minced pork instead of beef; it was a wrong purchase. At this point the user would edit the item in the fridge to reflect this mistake. If the shopping list was adjusted to also correct this mistake, it would be of value to the user.

---