search

larrymyers / react-mini-router

A minimal URL router for React.js
MIT License
282 stars 38 forks source link

Address #65, updating dependencies for karma, react, inlining getEventTarget #67

Closed kevinrobinson closed 7 years ago

kevinrobinson commented 7 years ago

Forking to address #65 upstream (related: https://github.com/larrymyers/react-mini-router/issues/66).

This updates dependencies for karma-cli and karma to work under Node 6:

$ npm install
...
npm ERR! notsup Unsupported engine for karma-cli@0.0.4: wanted: {"node":"~0.8 || ~0.10"} (current: {"node":"6.2.1","npm":"3.9.3"})
...
npm ERR! notsup Unsupported engine for karma@0.13.22: wanted: {"node":"0.10 || 0.12 || 4 || 5"} (current: {"node":"6.2.1","npm":"3.9.3"})
...

And updates react and react-dom to 15.4.1:

$ npm test
...
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "react/lib/ReactDOM"
  at undefined:3
...

And fixes the underlying issue with getEventTarget no longer being exposed by React by inlining the version that was previously in React 15.3.2:

$ npm test
...
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  Error: Cannot find module "react/lib/getEventTarget"
  at undefined:4
...

@larrymyers I'm not sure how you'd like to manage the project, but if this is useful merge away!

alexkrolick commented 7 years ago

Can this get merged?

EDIT: Or if PR #66 fixes the same issue, can we close issue #65?

alexkrolick commented 7 years ago

Another comment - even if this isn't merged, NPM needs to be updated with a version bump to get the existing workaround from #66 into the package system.