search

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

Fullscreen #107

Closed brunowonka closed 7 years ago

brunowonka commented 9 years ago

this is a quick addition to allow full-screen ad banners. It's not yet fully functional but does add useful functionality for simple applications. You have a way to call full-screen ads on the shared manager, the implementation tries to minimize friction with existing code. Currently only admob adapter summons fullscreen ads, but it should be simple enough to add it to iAd adapter, I'll try to get around to it.

larsacus commented 9 years ago

I had never intended for this library to support interstitials as a means to make this a drop-dead simple implementation of banners someone could use. Since interstitials are so different than banners, they require different code paths, which complicate both the internal implementation as well as the public interface.

I like what you've done here, but I'm not sure that it is appropriate for this class. I would consider it if there was some way to modulate this code into categories or some addition like extra files that someone can opt-in to by including the extra files. This way I could make the interstitials another CocoaPod subspec that anyone can add.

brunowonka commented 9 years ago

I hear you, that makes a lot of sense. Should be easy enough to decouple things. I can do it during the holidays. Get back to you soon. Cheers.