search

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

Notification on bannerViewActionShouldBegin and bannerViewActionDidFinish #113

Closed Djelibeybi closed 4 years ago

Djelibeybi commented 9 years ago

I can't seem to find a way to get notified via the LARSAdController for the standard iAd delegate methods, in particular bannerViewActionShouldBegin and bannerViewActionDidFinish.

I need to stop some activity before the ad is displayed modally and then resume the activity once the ad has completed, assuming the user returns to the app. Is there an existing mechanism to do this?

larsacus commented 9 years ago

I currently don't have support for this kind of callback since I don't have support for delegation on the ad controller itself - only callbacks for the controller's ad visibility. I did this in an effort to make this library serve the 80% use-case in as few lines of setup code as possible.

Djelibeybi commented 9 years ago

Ok, I've worked around this by modifying my local version of LARSAdController. Can I ask that this be added as a feature request for consideration?

larsacus commented 9 years ago

I'm always open to pull requests.