larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

Update constant to work with latest Google Ads SDK #117

Closed apptekstudios closed 9 years ago

apptekstudios commented 9 years ago

When using the latest google admob SDK the GAD_Simulator constant returns an error.

insanj commented 9 years ago

This should be accepted immediately: it's impossible to compile this library (with the iOS 7+ SDK) using the invalid GAD_SIMULATOR_ID constant.

larsacus commented 9 years ago

I have pushed v3.1.0 to Cocoapods with the above change. Take note, however, though -- I've been having extreme issues with both CocoaPods and google's pods in specific since Google decided to ship with a framework in 7.0. Add on top of this that Google decided to break their public API without revving the major version and we've arrived at this PR.

Note that to support the above change by Google, I have bumped up the minimum Google-Mobile-Ads-SDK version to ~> 7.2.

I highly recommend moving to Carthage over CocoaPods if you can support iOS >= 8.0. I don't have any specific steps for supporting this on this particular project, however, due to the complications around 1. Carthage requiring access to the git repo and 2. Google not providing git source-access.

I will try and keep supporting this project as long as I can.