search

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

always NSLog errors #66

Closed dwery closed 10 years ago

dwery commented 10 years ago

In the delegates, always NSLog the error code when an ad network fails. (Without using the LARSADCONTROLLER_DEBUG define)

larsacus commented 10 years ago

Are you wanting this in production, or just during development?

dwery commented 10 years ago

I'd say production, it shouldn't happen often

larsacus commented 10 years ago

Ad network "failures" are very common, since they will be thrown for instance whenever an ad network doesn't have inventory to display. The only logs that I show regardless are implementation errors or warnings that occur during development.

Is there a specific reason why you are interested in letting these logs display in your user's device console?

larsacus commented 10 years ago

I've updated the iAd adapter to display the specific error that is being returned from the system in didFailToReceiveAdWithError:: 90eb8808b8b6f784d64c09314c144f182f697bac. You will still need logging enabled.

dwery commented 10 years ago

nope, if they're common there's no point in showing them. ty.