Fixed a problem where AdMob ads did reappear after destroying all banners

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.

http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/

MIT License

269 stars 60 forks source link

Fixed a problem where AdMob ads did reappear after destroying all banners #90

Closed ghost closed 10 years ago

ghost commented 10 years ago

I noticed that the AdMob banner did reappear after destroying all banners. It turned out cleanup for the visible banner did never get called, since the completion block was not executed. It seems the animation has not yet finished when the completion block of "animateWithDuration" gets called. I see no disadvantageous effect in not checking for the finished flag.

larsacus commented 10 years ago

I'll take a look at this this week. :beer: