addAdContainerToViewInViewController doesn't recreate adapter instances after destroyAllAdBanners

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.

http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/

MIT License

269 stars 60 forks source link

addAdContainerToViewInViewController doesn't recreate adapter instances after destroyAllAdBanners #92

Closed Frugghi closed 10 years ago

Frugghi commented 10 years ago

In my app I need to show and hide the banners if certain conditions are met. If I call addAdContainerToViewInViewController, then destroyAllAdBanners and then addAdContainerToViewInViewController again the banners won't show up (the second time).

I fixed the issue and a couple of Xcode related issues. Note that Github forced me to delete AdMob submodule because it doesn't exist anymore and I don't know where I can find it.

larsacus commented 10 years ago

Yeah that admob submodule should have been removed a long time ago. Another reason not to go with submodules. Looks good to me.