search

larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

Landscape Banners #95

Closed glancashire closed 10 years ago

glancashire commented 10 years ago

Dear Lars,

Thanks for the last fix, but somehow the other changes in 3.0.6. broke landscape ads.

I only get 320x50 Banners in Landscape on a iPhone (IOS 7.1.2 in simulator).

This seems to go back to the following change:

TOLAdAdapteriAds.m

(void)layoutBannerForInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation{ +#if (IPHONE_OS_VERSION_MIN_REQUIRED < IPHONE_6_0)

If I get rid of the < pre iPhone 6 ifdef landscape ads appear once more as landscape.

Kind Regards Graham

larsacus commented 10 years ago

What version of iOS are you seeing the issue on? All versions? Only specific versions?

mrcmd commented 10 years ago

I can confirm the issue. It happens on all ios versions >=6 iff "ios deployment target" >= 6 in project settings.

No problem as long as you compile your project with deployment target 5. But if you create a ios7 only project, you'll have the issue.

The bug was introduced by the commit: https://github.com/larsacus/LARSAdController/commit/ee70c9f969e1e5fe96df0ad952602fb709555295

larsacus commented 10 years ago

So turns out in iOS 6 there was a totally new way to layout your banner view that was not being handled. It just now reared it's head when we tried to not use the old deprecated methods, but never had anything to replace it. It should function properly in master right now. I'll work on getting 3.0.7 pushed up.

larsacus commented 10 years ago

Just pushed up 3.0.7

glancashire commented 10 years ago

Thanks!