larsacus / LARSAdController

Lightweight ad mediation for iOS to properly manage multiple ad networks dynamically including iAd and Google ads.
http://theonlylars.com/blog/2013/01/10/stupid-easy-ads-with-larsadcontroller-3-dot-0/
MIT License
269 stars 60 forks source link

Incorrect Google Ad frame in landscape mode #98

Closed dafdafydd closed 10 years ago

dafdafydd commented 10 years ago

I have a problem with Google ad display on XCode 6 GM and iOS8 GM. When I turn my device or the simulator to landscape mode, the Google ad does not adapt to it and keeps the same as it had in the portrait mode. With iAd and iPad as well as on iOS7 and the version of the app built with XCode 5.1.1, everything works as expected.

I produced the logs. The iOS8 one shows the incorrect behaviour on iOS8's simulator (the same happens on the device) while in the iOS7 part, everything works fine on the iOS7 simulator.

iOS 8:

2014-09-15 00:48:46.189 Pronounce[2385:113736] LARSAdController [line 184]: View is portrait 2014-09-15 00:48:46.189 Pronounce[2385:113736] LARSAdController [line 207]: Container frame: {{0, 518}, {320, 50}} 2014-09-15 00:48:46.189 Pronounce[2385:113736] LARSAdController [line 533]: Creating new instance of adapter class "TOLAdAdapterGoogleAds" 2014-09-15 00:48:46.286 Pronounce[2385:113736] To get test ads on this device, call: request.testDevices = @[ GAD_SIMULATOR_ID ]; 2014-09-15 00:48:46.334 Pronounce[2385:113736] LARSAdController [line 567]: Successfully created instance of "TOLAdAdapterGoogleAds" 2014-09-15 00:48:46.335 Pronounce[2385:113736] LARSAdController [line 483]: Initial banner frame : {{0, 50}, {320, 50}} 2014-09-15 00:48:46.335 Pronounce[2385:113736] LARSAdController [line 509]: Final banner frame : {{0, 0}, {320, 50}} 2014-09-15 00:48:46.336 Pronounce[2385:113736] LARSAdController [line 711]: Registering for orientation notifications 2014-09-15 00:48:46.336 Pronounce[2385:113736] LARSAdController [line 184]: View is portrait 2014-09-15 00:48:46.336 Pronounce[2385:113736] LARSAdController [line 207]: Container frame: {{0, 518}, {320, 50}} 2014-09-15 00:48:46.336 Pronounce[2385:113736] LARSAdController [line 509]: Final banner frame : {{0, 0}, {320, 50}} 2014-09-15 00:48:46.352 Pronounce[2385:113736] did enter foreground notification 2014-09-15 00:48:47.484 Pronounce[2385:113736] TOLAdAdapterGoogleAds [line 108]: Google ad did receive ad 2014-09-15 00:48:49.341 Pronounce[2385:113736] LARSAdController [line 737]: Handling orientation change 2014-09-15 00:48:49.349 Pronounce[2385:113736] LARSAdController [line 175]: View is landscape 2014-09-15 00:48:49.349 Pronounce[2385:113736] LARSAdController [line 207]: Container frame: {{0, 270}, {568, 50}} 2014-09-15 00:48:49.354 Pronounce[2385:113736] LARSAdController [line 509]: Final banner frame : {{124, 18}, {320, 32}} 2014-09-15 00:48:49.620 Pronounce[2385:113736] TOLAdAdapterGoogleAds [line 108]: Google ad did receive ad 2014-09-15 00:48:50.087 Pronounce[2385:113736] TOLAdAdapterGoogleAds [line 108]: Google ad did receive ad

iOS 7:

2014-09-15 00:48:12.989 Pronounce[2294:607] LARSAdController [line 184]: View is portrait 2014-09-15 00:48:12.989 Pronounce[2294:607] LARSAdController [line 207]: Container frame: {{0, 518}, {320, 50}} 2014-09-15 00:48:12.989 Pronounce[2294:607] LARSAdController [line 533]: Creating new instance of adapter class "TOLAdAdapterGoogleAds" 2014-09-15 00:48:13.041 Pronounce[2294:607] To get test ads on this device, call: request.testDevices = @[ GAD_SIMULATOR_ID ]; 2014-09-15 00:48:13.043 Pronounce[2294:607] LARSAdController [line 567]: Successfully created instance of "TOLAdAdapterGoogleAds" 2014-09-15 00:48:13.044 Pronounce[2294:607] LARSAdController [line 483]: Initial banner frame : {{0, 50}, {320, 50}} 2014-09-15 00:48:13.044 Pronounce[2294:607] LARSAdController [line 509]: Final banner frame : {{0, 0}, {320, 50}} 2014-09-15 00:48:13.045 Pronounce[2294:607] LARSAdController [line 711]: Registering for orientation notifications 2014-09-15 00:48:13.045 Pronounce[2294:607] LARSAdController [line 184]: View is portrait 2014-09-15 00:48:13.045 Pronounce[2294:607] LARSAdController [line 207]: Container frame: {{0, 518}, {320, 50}} 2014-09-15 00:48:13.045 Pronounce[2294:607] LARSAdController [line 509]: Final banner frame : {{0, 0}, {320, 50}} 2014-09-15 00:48:13.051 Pronounce[2294:607] did enter foreground notification 2014-09-15 00:48:13.051 Pronounce[2294:607] LARSAdController [line 737]: Handling orientation change 2014-09-15 00:48:13.064 Pronounce[2294:607] LARSAdController [line 184]: View is portrait 2014-09-15 00:48:13.064 Pronounce[2294:607] LARSAdController [line 207]: Container frame: {{0, 518}, {320, 50}} 2014-09-15 00:48:13.065 Pronounce[2294:607] LARSAdController [line 509]: Final banner frame : {{0, 0}, {320, 50}} 2014-09-15 00:48:13.508 Pronounce[2294:607] TOLAdAdapterGoogleAds [line 108]: Google ad did receive ad 2014-09-15 00:48:16.933 Pronounce[2294:607] LARSAdController [line 737]: Handling orientation change 2014-09-15 00:48:16.936 Pronounce[2294:607] LARSAdController [line 175]: View is landscape 2014-09-15 00:48:16.936 Pronounce[2294:607] LARSAdController [line 207]: Container frame: {{0, 270}, {568, 50}} 2014-09-15 00:48:16.944 Pronounce[2294:607] LARSAdController [line 509]: Final banner frame : {{0, 18}, {568, 32}} 2014-09-15 00:48:17.110 Pronounce[2294:607] TOLAdAdapterGoogleAds [line 108]: Google ad did receive ad

mrcmd commented 10 years ago

I can confirm the issue.

However, I think it is a bug in admob and not LARSAdController: https://groups.google.com/forum/#!topic/google-admob-ads-sdk/nT1n7VqSjOk

dafdafydd commented 10 years ago

Thanks for the info. Thankfully I managed to download XCode 5.1.1 and submit an iOS8 build with it.

larsacus commented 10 years ago

If this in fact a bug in google ads, you can specify a lower version of the pod in your pod file and it will pull down that version.