search

larsbeck / HomematicIp

This package allows to query the HomematicIp REST and WebSocket endpoint.
MIT License
7 stars 2 forks source link

HEATING_THERMOSTAT_COMPACT device missing #28

Closed obartelt closed 4 years ago

obartelt commented 4 years ago

The HEATING_THERMOSTAT_COMPACT device is missing. Otherwise, great work!

larsbeck commented 4 years ago

Thanks for the kind words! I can add the device, but I will need the Json object from the UnknownHomematicObjectException. You can see what it roughly looks like in one of the closed issues, like https://github.com/larsbeck/HomematicIp/issues/24 Or if you can add the device yourself, feel free to send me a pull request.

obartelt commented 4 years ago

I assume it's just the same as HEATING_THERMOSTAT. At least I copied the device into another class, and it works. Maybe there are additional properties, but the de-serialization works, at least. After all, it's just another heating thermostat, just compact ;-)

larsbeck commented 4 years ago

I have added HEATING_THERMOSTAT_COMPACT to the EnumMap of HeatingThermostat. Thanks for reporting this!