search

larsbrinkhoff / forth-mode

Wants to be the SLIME of Forth
GNU General Public License v3.0
61 stars 17 forks source link

Don't kill the *forth* buffer #22

Closed ellerh closed 7 years ago

ellerh commented 7 years ago

forth-interaction-sentinel kills the *forth* buffer. I think that's counter productive, especially when the subprocess just crashed.

larsbrinkhoff commented 7 years ago

Sure, I added the sentinel function, but I wasn't sure what to use it for.

You want the buffer to linger with a dead process? I suppose run-forth has to clean up and start a new process then.

Do you have any suggestion what to do when the sentinel runs?

ellerh commented 7 years ago

You want the buffer to linger with a dead process?

Yes, as the output in the *forth* buffer is usually the first clue for finding the problem. The buffer would probably not have a "dead process"; it simply has no process.

I suppose run-forth has to clean up and start a new process then.

Yes. Addmittedly, reinitializing the buffer is a bit more fiddly.

Do you have any suggestion what to do when the sentinel runs?

Displaying the message as now seems fine. Perhaps with an additional ding.

larsbrinkhoff commented 7 years ago

Ok, I'll look into this in the near future.

larsbrinkhoff commented 7 years ago

I guess it's as simple as that.