Include tab (\t) as delimiter for comments.

larsbrinkhoff / forth-mode

Wants to be the SLIME of Forth

GNU General Public License v3.0

61 stars 17 forks source link

Include tab (\t) as delimiter for comments. #29

Closed ellerh closed 7 years ago

ellerh commented 7 years ago

test/tests.el (forth-backslash-comment-font-lock) (forth-paren-comment-font-lock): New tests.
forth-mode.el (forth--syntax-propertize): Handle the new test cases.

larsbrinkhoff commented 7 years ago

(forth-assert-face "(foo) " 3 nil) and (forth-assert-face "a\\b " 2 nil) fail in Emacs 23. Any idea why?

ellerh commented 7 years ago

In Emacs23 (boundp 'syntax-propertize-function) => nil. Apparently this was introduced in Emacs24.

ellerh commented 7 years ago

I think it would be reasonable to drop support for Emacs23 as 23 is now quite old Testing with Emacs25 and Emacs24 seems more productive than backporting things to Emacs23.

larsbrinkhoff commented 7 years ago

Superceded by #31, I understand?

larsbrinkhoff commented 7 years ago

I think it would be reasonable to drop support for Emacs23 as 23 is now quite old

I agree it's not worth any significant effort to support Emacs 23. I'd like to keep some minimal support by e.g. reducing functionality or disabling tests.