search

larsbrinkhoff / terminal-simulator

Simulation of VT52 and VT100 terminal hardware.
GNU General Public License v3.0
113 stars 17 forks source link

Cell rendering bugs #30

Open SegHaxx opened 3 years ago

SegHaxx commented 3 years ago

Going to collect together cell rendering bugs here.

Looking at https://github.com/larsbrinkhoff/terminal-simulator/issues/5#issuecomment-845654823 in particular confirms something, chars should not touch the left side of the inverse cell? This is what it looks like now:

image

Also of note I don't see underline anywhere.

The obvious fix is to bump it to the right one dotclock, which does look nicer:

image image

But it messes up boxdrawing:

image

What does a real VT100 do? Lars can you get photos of these vttest screens? :) (end of "Test of screen features")

larsbrinkhoff commented 3 years ago

What does a real VT100 do? Lars can you get photos of these vttest screens?

Sure, no problem. When I get back home.

I think it would be best to implement the video generation as documented in the Tech manual. I.e. the detailed process of loading data from the character ROM and feeding it through a shift register. Hopefully this should take care of making everything look exactly right.

larsbrinkhoff commented 3 years ago

Also of note I don't see underline anywhere.

This is currently a documented limitation of the simulator: "The Advanced Video Option is not included." This means underline or inverse video are selected from SET-UP B and can not be viewed simultaneously. The AVO adds four attribute bits per character so can display underline, inverse, dim, bright, and blink.