larsbs / id3v2lib

id3v2lib is a library written in C to read and edit id3 tags from mp3 files.
BSD 2-Clause "Simplified" License
128 stars 44 forks source link

ID3v2_Tag_get_frame now takes const char* and moved TagHeader_free to public header. #46

Closed sizeak closed 1 year ago

sizeak commented 1 year ago

fixes #44 fixes #45

larsbs commented 1 year ago

LGTM, thanks for your contribution! 👍

sizeak commented 1 year ago

And thank you for the library!

On Mon, 29 May 2023, 19:02 Lars, @.***> wrote:

Merged #46 https://github.com/larsbs/id3v2lib/pull/46 into master.

— Reply to this email directly, view it on GitHub https://github.com/larsbs/id3v2lib/pull/46#event-9370999291, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANW6OM4K7EDLZ2SKHUXJYPTXITQFDANCNFSM6AAAAAAYTATJFQ . You are receiving this because you authored the thread.Message ID: @.***>

sizeak commented 1 year ago

@larsbs Would you mind publishing a new release tag that includes these changes, I need to be able to pull a tarball for a Conan recipe. Thanks!

larsbs commented 1 year ago

@simoncent done, you can find the changes under the release tag 2.1

sizeak commented 1 year ago

Excellent, thank you 👍🏻

sizeak commented 1 year ago

Conan package PR is here if you;re interested https://github.com/conan-io/conan-center-index/pull/17779