search

larsbs / id3v2lib

id3v2lib is a library written in C to read and edit id3 tags from mp3 files.
BSD 2-Clause "Simplified" License
128 stars 44 forks source link

compiling and running without segfault #9

Closed moritzschaefer closed 9 years ago

moritzschaefer commented 9 years ago

From issue 8:

It would be helpful to add buffer read support besides file reading. I am implementing a file streamer/player at the moment and want to read id3 data directly from the stream.

There is no library available (i know of) that reads id3 labels from a buffer rather than from a file.

I added methods for being able to use buffers instead of files. The functionality is not broken as all the functions still do the same as they did before. I added new functions for the new functionality.

Please check out the code and let me know what you think of it.

larsbs commented 9 years ago

Very interesting work, as soon as I have some free time (maybe on weekend) I'll review the code and merge it if everything goes ok.

moritzschaefer commented 9 years ago

push. did you find time to review the code already? best regards and a happy new year.

hopeseekr commented 8 years ago

Was this Pull Request ever tested, by anybody?!?! It totally doesn't work and breaks the app in critical ways!~ See Issue #12, "It just doesn't read tags!".