search

larsch / cmake-precompiled-header

Visual Studio and GCC precompiled header macro for CMake
160 stars 42 forks source link

Adds support for precompiled headers in Ninja builds with Visual Studio targets #3

Closed mwiebe closed 8 years ago

mwiebe commented 8 years ago

The mechanism for the fix is from https://cmake.org/pipermail/cmake-developers/2012-March/015380.html.

There's also a fix for an issue I ran into where the Windows precompiled header files didn't work out of the box on Linux.

larsch commented 8 years ago

Hi Mark, Thanks for the pull request!

Is the guard around setting OBJECT_DEPENDS necessary? I have not included this and all tests pass. Otherwise, merged.

I've not included c8c1f02 as it may break builds that rely on certain include paths and their order. You could possibly add this in your own CMakeLists.txt if needed.

I have added tests for Linux (Makefiles and Ninja) and they all work (although they all use out-of-source builds).

mwiebe commented 8 years ago

Thanks for merging and adding the tests! I've tested the OBJECT_DEPENDS, and the visual studio projects it generates look basically the same either way, so that does appear unnecessary as you suspected.